[PATCH] D137727: [SPARC] Simplify instruction decoder.

[James Y Knight via Phabricator via llvm-commits]

jyknight added a comment.

In D137727#3939675 <https://reviews.llvm.org/D137727#3939675>, @koakuma wrote:

> The patch doesn't apply cleanly as-is on my test system (seems like there are some of the proposed changes that's already in main?).

It depends on https://reviews.llvm.org/D137653 which is not yet committed.



================
Comment at: llvm/test/MC/Disassembler/Sparc/sparc-coproc.txt:1
+# RUN: llvm-mc --disassemble %s -triple=sparcv9-unknown-linux | FileCheck %s
+
----------------
koakuma wrote:
> Coprocessor instructions are only available in v8.
> v9 reassigned the encoding to other instructions (see §A.23 and §A.53 of the v9 ISA spec, for example), so I think the decoder should differentiate between the two meanings, if possible.
I will switch the test to test v8, but changing the instruction definition to be v8-only is out of scope for this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137727/new/

https://reviews.llvm.org/D137727