[PATCH] D138359: [TableGen] CheckSchedClassTables - check for unnecessary scheduler overrides

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/utils/TableGen/CodeGenSchedule.cpp:1149
     for (Record *InstDef : InstDefs)
-      InstrClassMap[InstDef] = SCIdx;
+      InstrClassMap[InstDef].second = SCIdx;
     SC.InstRWs.push_back(InstRWDef);
----------------
Something we could consider is checking here if the base and override classes COMPLETELY match and just don't bother using the override class? We should probably still warn though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138359/new/

https://reviews.llvm.org/D138359