[PATCH] D138361: [cmake] Fix Findzstd.cmake to handle OpenBSD shared libraries

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

I don't know much of the cmake mechanism, so I can only provide tests on Debian testing. I'll leave it to @brad and @phosek 
This patch works with the `libzstd-dev` package.

  % grep -i ZSTD /tmp/out/custom2/CMakeCache.txt
  //Use zstd for compression/decompression if available. Can be ON,
  LLVM_ENABLE_ZSTD:STRING=ON
  //Use static version of zstd. Can be TRUE, FALSE
  LLVM_USE_STATIC_ZSTD:BOOL=FALSE
  zstd_INCLUDE_DIR:PATH=/usr/include
  zstd_LIBRARY:FILEPATH=/usr/lib/x86_64-linux-gnu/libzstd.so
  zstd_STATIC_LIBRARY:FILEPATH=/usr/lib/x86_64-linux-gnu/libzstd.a
  //ADVANCED property for variable: zstd_INCLUDE_DIR
  zstd_INCLUDE_DIR-ADVANCED:INTERNAL=1
  //ADVANCED property for variable: zstd_LIBRARY
  zstd_LIBRARY-ADVANCED:INTERNAL=1
  //ADVANCED property for variable: zstd_STATIC_LIBRARY
  zstd_STATIC_LIBRARY-ADVANCED:INTERNAL=1
  
  # with a -DCMAKE_PREFIX_PATH=/tmp/p/zstd/out/release build
  % grep -i ZSTD /tmp/out/custom2/CMakeCache.txt
  CMAKE_PREFIX_PATH:UNINITIALIZED=/tmp/p/zstd/out/release
  //Use zstd for compression/decompression if available. Can be ON,
  LLVM_ENABLE_ZSTD:STRING=ON
  //Use static version of zstd. Can be TRUE, FALSE
  LLVM_USE_STATIC_ZSTD:BOOL=FALSE
  zstd_INCLUDE_DIR:PATH=/usr/include
  zstd_LIBRARY:FILEPATH=/tmp/p/zstd/out/release/lib/libzstd.so
  zstd_STATIC_LIBRARY:FILEPATH=/tmp/p/zstd/out/release/lib/libzstd.a
  //ADVANCED property for variable: zstd_INCLUDE_DIR
  zstd_INCLUDE_DIR-ADVANCED:INTERNAL=1
  //ADVANCED property for variable: zstd_LIBRARY
  zstd_LIBRARY-ADVANCED:INTERNAL=1
  //ADVANCED property for variable: zstd_STATIC_LIBRARY
  zstd_STATIC_LIBRARY-ADVANCED:INTERNAL=1


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138361/new/

https://reviews.llvm.org/D138361