[PATCH] D138351: [SVE] Fix incorrect predicate for fixed length int/fp conversion.
Paul Walker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Nov 19 04:40:08 PST 2022
paulwalker-arm added reviewers: bsmith, david-arm.
paulwalker-arm added a subscriber: hassnaa-arm.
paulwalker-arm added a comment.
@hassnaa-arm: Just a heads up that this patch will affect the output for some of the tests you're adding as part of D136858 <https://reviews.llvm.org/D136858>.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:23037
- if (ContainerSrcVT.getVectorElementType().getSizeInBits() <=
- ContainerDstVT.getVectorElementType().getSizeInBits()) {
+ if (VT.bitsGT(SrcVT)) {
EVT CvtVT = ContainerDstVT.changeVectorElementType(
----------------
NOTE: Although using `bitsGE` maintains the original behaviour, I figure for the `EQ` case the else block is simpler and so might save a few cycles of compile time whilst having no affect on the generated code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138351/new/
https://reviews.llvm.org/D138351
More information about the llvm-commits
mailing list