[PATCH] D135957: [AArch64][SeperateConstOffsetFromGEP] Prevent pass from splitting GEP if an index has more than one use

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

> Actually this causes more tests to fail. I think for now doing it for only GEPs with one operand is fine. What do you think @dmgreen

Hello. Hmm. It's hard to tell without doing a lot of experimenting. Do you have examples of the failing tests? Are they getting worse, or just different?

I feel like you have identified a real problem here, but the solution doesn't look very general. It seems, perhaps without knowing enough about the details yet, that ConstantOffsetExtractor::Extract should be considering the uses more than it does.

Let me run some experiments. We've had another report of SeparateConstOffsetFromGEP (or - specifically the CSE) causing issues. It may be better to revert it for the time being.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135957/new/

https://reviews.llvm.org/D135957