[PATCH] D138332: [Passes] Don't add CHR pass for CSIRInstr build in PostLink

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 15:27:54 PST 2022


tejohnson added a comment.

Where is the CSFDO annotation step in relation to this pass? If it would be annotated before this point on the subsequent CSFDO use compile, is the idea that we might as well wait for the CSFDO profile before performing post-link CHR?

Presumably even if the profile is the same as the pre-link CHR, the code could be different after cross-module importing, inlining, other cleanup, so wouldn't that open up more opportunities potentially for CHR?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138332/new/

https://reviews.llvm.org/D138332



More information about the llvm-commits mailing list