[PATCH] D124385: AMDGPU: Special case divergence analysis for wave ID computation

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 12:41:52 PST 2022


arsenm added a comment.

In D124385#3937998 <https://reviews.llvm.org/D124385#3937998>, @arsenm wrote:

> In D124385#3484855 <https://reviews.llvm.org/D124385#3484855>, @nhaehnle wrote:
>
>> I have a bunch of questions about this.
>
> I've come back to this several times and been confused each time. I did write a program that convinced me that this is correct, and doesn't need to consider partial workgroups.

The partial workgroup check is implicit in the pattern checked here. The uniform workgroup size attribute triggers optimizations on the group calculation. There's additional complexity on the group size load if that didn't trigger


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124385/new/

https://reviews.llvm.org/D124385



More information about the llvm-commits mailing list