[PATCH] D138244: Revert "Reapply: Add an error message to the default SIGPIPE handler"
Bill Wendling via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 18 11:23:40 PST 2022
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4787efa38066: Revert "Reapply: Add an error message to the default SIGPIPE handler" (authored by void).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138244/new/
https://reviews.llvm.org/D138244
Files:
llvm/lib/Support/Unix/Signals.inc
llvm/test/Support/unix03-sigpipe-exit.test
Index: llvm/test/Support/unix03-sigpipe-exit.test
===================================================================
--- llvm/test/Support/unix03-sigpipe-exit.test
+++ /dev/null
@@ -1,26 +0,0 @@
-## Test that when writing to a closed stdout, LLVM tools finish with a non-zero
-## exit code and an error message on stderr. The test uses llvm-cxxfilt, but
-## it's a logic from the default SIGPIPE handler, so it applies to all the tools.
-## This is required for UNIX03 conformance.
-
-# UNSUPPORTED: system-windows
-
-# RUN: not %python %s llvm-cxxfilt 2>&1 | FileCheck %s
-# CHECK: error: write on a pipe with no reader
-
-import subprocess
-import sys
-
-with subprocess.Popen([sys.argv[1]], stdout=subprocess.PIPE, stdin=subprocess.PIPE) as process:
- process.stdout.close()
-
- # llvm-cxxfilt with no extra arguments runs interactively and writes input
- # to output. Writing continuously to stdin should trigger SIGPIPE when the
- # subprocess attempts to write out bytes to a closed stdout.
- try:
- while True:
- process.stdin.write("foo\n".encode("utf-8"))
- except BrokenPipeError:
- # Clear stdin, pipe is broken and closing it on cleanup will raise an exception.
- process.stdin = None
-sys.exit(process.returncode)
Index: llvm/lib/Support/Unix/Signals.inc
===================================================================
--- llvm/lib/Support/Unix/Signals.inc
+++ llvm/lib/Support/Unix/Signals.inc
@@ -432,10 +432,6 @@
}
void llvm::sys::DefaultOneShotPipeSignalHandler() {
- // UNIX03 conformance requires a non-zero exit code and an error message
- // to stderr when writing to a closed stdout fails.
- errs() << "error: write on a pipe with no reader\n";
-
// Send a special return code that drivers can check for, from sysexits.h.
exit(EX_IOERR);
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138244.476535.patch
Type: text/x-patch
Size: 1801 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221118/c483df5f/attachment.bin>
More information about the llvm-commits
mailing list