[PATCH] D137352: [scudo] Detect double free when running with MTE.

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 11:04:31 PST 2022


fmayer added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:571
+    if (useMemoryTagging<Params>(Options) && Size != 0)
+      *(char volatile *)TaggedPtr;
+
----------------
nit: afaict llvm uses `const char`, so I think this should be `volatile char` for consistency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137352/new/

https://reviews.llvm.org/D137352



More information about the llvm-commits mailing list