[PATCH] D138044: AMDGPU/GlobalISel: Fix crash after mad/fma_mix fails selection

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 08:44:04 PST 2022


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-add-mul.ll:173-174
+  %abs_x = call contract float @llvm.fabs.f32(float %x)
+  %a = fmul contract float %abs_x, %y
+  %b = fadd contract float %a, %z
+  ret float %b
----------------
arsenm wrote:
> Should pre-contract this 
Should still use fmuladd or fma intrinsic here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138044/new/

https://reviews.llvm.org/D138044



More information about the llvm-commits mailing list