[PATCH] D128159: [DAG] Enable scalable vectors handling in computeKnownBits
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 18 08:35:46 PST 2022
reames added a comment.
FYI, D137140 <https://reviews.llvm.org/D137140> so this patch is now mostly redundant.
I went back to look at the two parts I left out. From the original commit message that was:
"Adds some simple known bits for ISD::STEP_VECTOR, which for power-two increments we know lower bit zeroes."
"The patterns for INDEX were made to work with adds or add-like-ors, to keep them working as intended."
I applied both of these changes locally, and saw no test difference. Either individually or together. Given that, I'm not going to push those further until we have a motivating example or a test in tree. Feel free to split into it's own patch - with appropriate test - if desired. I'd be happy to review.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128159/new/
https://reviews.llvm.org/D128159
More information about the llvm-commits
mailing list