[PATCH] D138299: [bolt] Clean up lit site cfg files a bit

[Nico Weber via Phabricator via llvm-commits]

thakis created this revision.
thakis added reviewers: rafaelauler, bolt.
Herald added a reviewer: rafauler.
Herald added subscribers: treapster, ayermolo.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
thakis requested review of this revision.
Herald added a subscriber: yota9.

- Stop setting config.python_executable in Unit/lit.site.cfg.py.in. All other projects only set this in the main lit config, not in the one for unit tests. (Unit tests don't spawn Python.)
- Set config.python_executable to Python3_EXECUTABLE in main lit.site.cfg.py.in instead of PYTHON_EXECUTABLE. All other files did this in c4c3883b00 <https://reviews.llvm.org/rGc4c3883b00d3a6aa657a5e3e515c90c9ea1f81c6>.
- Stop setting enable_abi_breaking_checks, enable_backtrace, enable_shared. Nothing in bolt's tests (or in lit) reads them.


https://reviews.llvm.org/D138299

Files:
  bolt/test/Unit/lit.site.cfg.py.in
  bolt/test/lit.site.cfg.py.in


Index: bolt/test/lit.site.cfg.py.in
===================================================================
--- bolt/test/lit.site.cfg.py.in
+++ bolt/test/lit.site.cfg.py.in
@@ -14,11 +14,8 @@
 config.host_triple = "@LLVM_HOST_TRIPLE@"
 config.target_triple = "@LLVM_TARGET_TRIPLE@"
 config.llvm_use_sanitizer = "@LLVM_USE_SANITIZER@"
-config.enable_shared = @ENABLE_SHARED@
-config.enable_backtrace = @ENABLE_BACKTRACES@
 config.host_arch = "@HOST_ARCH@"
-config.enable_abi_breaking_checks = "@LLVM_ENABLE_ABI_BREAKING_CHECKS@"
-config.python_executable = "@PYTHON_EXECUTABLE@"
+config.python_executable = "@Python3_EXECUTABLE@"
 config.bolt_clang = "@BOLT_CLANG_EXE@"
 config.bolt_lld = "@BOLT_LLD_EXE@"
 config.targets_to_build = "@TARGETS_TO_BUILD@"
Index: bolt/test/Unit/lit.site.cfg.py.in
===================================================================
--- bolt/test/Unit/lit.site.cfg.py.in
+++ bolt/test/Unit/lit.site.cfg.py.in
@@ -9,7 +9,6 @@
 config.bolt_obj_root = "@BOLT_BINARY_DIR@"
 config.bolt_src_root = "@BOLT_SOURCE_DIR@"
 config.target_triple = "@LLVM_TARGET_TRIPLE@"
-config.python_executable = "@Python3_EXECUTABLE@"
 
 import lit.llvm
 lit.llvm.initialize(lit_config, config)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138299.476474.patch
Type: text/x-patch
Size: 1197 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221118/01039356/attachment.bin>