[PATCH] D138218: [llvm-ar] Fix when llvm-ar fails to replace existing members when updating a thin archive

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo marked an inline comment as done.
gbreynoo added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/thin-archive-relative-path.test:9
+
+RUN: llvm-ar cr --thin foo/lib.a foo/elf.o
+RUN: llvm-ar t foo/lib.a  | FileCheck %s --check-prefix=FOO --implicit-check-not {{.}}
----------------
MaskRay wrote:
> If I do `llvm-ar cr --thin foo/lib.a foo/elf.o foo/elf.o`, what's the expected behavior?
We follow GNU ar, two copies of `foo/elf.o` are added, replacing an existing member if it is already in the archive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138218/new/

https://reviews.llvm.org/D138218