[PATCH] D137837: [Support] Move Target/CPU Printing out of CommandLine

Fri Nov 18 02:48:34 PST 2022

lenary added a comment.

In D137837#3922950 <https://reviews.llvm.org/D137837#3922950>, @MaskRay wrote:

> Personally I think the CPU info is not useful for all tools. 
> For most programs I have run which support `--version`, they don't print target-triple/CPU information. And a lot among them do have target-specific behavior (e.g. Windows/*NIX distinction). So LLVM CommandLine.cpp doing this by default is very strange to me.
> I see that you want to retain the existing behavior, though. I want to learn about others opinions. Perhaps ask on Discourse?
>
> I mentioned `llvm/Support/Host.h` but that was for a middle ground if there turns out to be sufficient support for retaining the information. So I suggested: for the tools which have `+ #include "llvm/Support/Host.h"` in this diff, I think `cl::AddExtraVersionPrinter` should be dropped.
> But perhaps we just don't need to do that :)

I have updates to the whole patch sequence, so I will do this latter change, and then ask for further opinions on discourse. :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137837/new/

https://reviews.llvm.org/D137837