[PATCH] D138277: TableGen: include in libLLVM-*.so

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 02:40:48 PST 2022


nhaehnle created this revision.
Herald added a project: All.
nhaehnle requested review of this revision.
Herald added a project: LLVM.

Use of TableGen has grown over the years, so the claim that it is for
internal use only carries less and less water.

The main motivation for adding it to the dylib is to cleanup linking of
tablegen tools outside of llvm itself.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138277

Files:
  llvm/tools/llvm-shlib/CMakeLists.txt


Index: llvm/tools/llvm-shlib/CMakeLists.txt
===================================================================
--- llvm/tools/llvm-shlib/CMakeLists.txt
+++ llvm/tools/llvm-shlib/CMakeLists.txt
@@ -17,10 +17,6 @@
 
   llvm_map_components_to_libnames(LIB_NAMES ${LLVM_DYLIB_COMPONENTS})
 
-  # Exclude libLLVMTableGen for the following reasons:
-  #  - it is only used by internal *-tblgen utilities;
-  list(REMOVE_ITEM LIB_NAMES "LLVMTableGen")
-
   if(LLVM_DYLIB_EXPORTED_SYMBOL_FILE)
     set(LLVM_EXPORTED_SYMBOL_FILE ${LLVM_DYLIB_EXPORTED_SYMBOL_FILE})
     add_custom_target(libLLVMExports DEPENDS ${LLVM_EXPORTED_SYMBOL_FILE})


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138277.476399.patch
Type: text/x-patch
Size: 634 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221118/f8e1c816/attachment.bin>


More information about the llvm-commits mailing list