[PATCH] D133310: [Assignment Tracking][15/*] Account for assignment tracking in simplifycfg

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 02:17:13 PST 2022


Orlando added a comment.

Removed `sink-erase.ll` as it was testing the `TryToSimplifyUncondBranchFromEmptyBlock` changes that we removed from this patch earlier.



================
Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/simplifycfg/sink-erase.ll:27-29
+;; Check that there is only one dbg.assign (for c) in the final block.
+; CHECK: for.inc.split.5:
+; CHECK-COUNT-1: call void @llvm.dbg.assign
----------------
jmorse wrote:
> Is that just checking a single block, and if not should there be an implicit-check-not happening?
"Check that there is only one dbg.assign (for c) in the final block." -> "Check that the final block only contains one dbg.assign"

This test isn't actually needed anymore - it was testing the `TryToSimplifyUncondBranchFromEmptyBlock` changes that we removed from this patch earlier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133310/new/

https://reviews.llvm.org/D133310



More information about the llvm-commits mailing list