[PATCH] D138211: [AArch64-SVE][StreamingMode]: force generating valid instr during copying phy reg.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Thanks for this change @hassnaa-arm. The patch looks good, just added two nits.

Could you change the title to something like this:

> [AArch64][SME]: Use SVE mov instruction for FPR128 registers in streaming-compatible mode.

such that it has:

- Proper capitalisation
- [AArch64] as the target description, [SME] for the sub-topic
- A slightly more descriptive title



================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-test-register-mov.ll:5
+target triple = "aarch64-unknown-linux-gnu"
+
+define fp128 @test_streaming_compatible_register_mov(fp128 %q0, fp128 %q1) #0 {
----------------
nit: Can you add a comment to describe the rationale behind the test (i.e. that a NEON Q-register mov is not valid in streaming mode, but an SVE Z-register mov is)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138211/new/

https://reviews.llvm.org/D138211