[PATCH] D136949: [Debugify] Accumulate the number of variables in debugify metadata

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineDebugify.cpp:165
+    setDebugifyOperand(1, OldNumVars + VarSet.size());
   }
 
----------------
LGTM here


================
Comment at: llvm/lib/CodeGen/MachineDebugify.cpp:176
+    if (auto *NMD = M.getNamedMetadata("llvm.mir.debugify"))
+      M.eraseNamedMetadata(NMD);
     MachineModuleInfo &MMI =
----------------
Here is runOnModule not runOnFunction, so I think here should only has 1 "llvm.mir.debugify".
I think the process should be "run 1 time debugfy for a module" --> optimizations--> "debugfy check" -->  "clear the debugify info before next debugify cycle"
Sorry for the code is a little long time for me.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136949/new/

https://reviews.llvm.org/D136949