[PATCH] D137440: [RISCV][llvm-mca] Use LMUL Instruments to provide more accurate reports on RISCV

[Michael Maitland via Phabricator via llvm-commits]

michaelmaitland marked an inline comment as not done.
michaelmaitland added inline comments.


================
Comment at: llvm/include/llvm/MCA/CustomBehaviour.h:130
+
+  Instrument() : Desc(""), Data("") {}
+
----------------
myhsu wrote:
> `Instrument() = default` or even without one should suffice
I cannot use this constructor form because N4659[dcl.init]p7.4), since:

- the default constructor for `StringRef` is not user-provided, following N4659[dcl.fct.def.default]p5

- the field `Desc` and `Data` are not const-default-constructible and has no default member initializer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137440/new/

https://reviews.llvm.org/D137440