[PATCH] D135411: Add generic KCFI operand bundle lowering

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 14:40:25 PST 2022


MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/KCFI.cpp:16
+#include "llvm/ADT/Statistic.h"
+#include "llvm/CodeGen/TargetLowering.h"
+#include "llvm/CodeGen/TargetSubtargetInfo.h"
----------------
Sorry, I just noticed this include. lib/Transforms/ files cannot depend on CodeGen for layering. You can see that no other Instrumentation uses CodeGen/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135411/new/

https://reviews.llvm.org/D135411



More information about the llvm-commits mailing list