[PATCH] D138215: [AMDGPU][CodeGen] Support raw format TFE buffer loads other than byte, short and d16 ones.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 13:16:40 PST 2022


arsenm added a comment.

I thought TFE was already handled?



================
Comment at: llvm/lib/Target/AMDGPU/BUFInstructions.td:1304-1305
+defm : MUBUF_LoadIntrinsicPat<SIbuffer_load_format_tfe, v2i32, "BUFFER_LOAD_FORMAT_X_TFE">;
+defm : MUBUF_LoadIntrinsicPat<SIbuffer_load_format_tfe, v3f32, "BUFFER_LOAD_FORMAT_XY_TFE">;
+defm : MUBUF_LoadIntrinsicPat<SIbuffer_load_format_tfe, v3i32, "BUFFER_LOAD_FORMAT_XY_TFE">;
+defm : MUBUF_LoadIntrinsicPat<SIbuffer_load_format_tfe, v4f32, "BUFFER_LOAD_FORMAT_XYZ_TFE">;
----------------
Why do these need fp and integer patterns? Given you've got the integer high element, I'd expect this to always be int vector 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138215/new/

https://reviews.llvm.org/D138215



More information about the llvm-commits mailing list