[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 13:10:18 PST 2022


rnk added a subscriber: dblaikie.
rnk added a comment.

I was going to approve it as is, since it looks like a correct simplification.

Relatedly, @dblaikie was considering establishing the invariant that all empty functions have at least one trap instruction, although for this code the entry BB could conceivably be empty, and you should handle that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137642/new/

https://reviews.llvm.org/D137642



More information about the llvm-commits mailing list