[PATCH] D138231: [CSSPGO][Preinliner] Use one for zero-sized functions when computing inline budge
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 17 12:06:45 PST 2022
hoy planned changes to this revision.
hoy added a comment.
In D138231#3934734 <https://reviews.llvm.org/D138231#3934734>, @wlei wrote:
> I think we actually will use the `ProfileInlineLimitMin` which is 100 for the count, see `SizeLimit = std::max(SizeLimit, (unsigned)ProfileInlineLimitMin);`
>
> `ProfileInlineGrowthLimit` is by default set to 12, and 1 * 12 is still smaller than 100.
Oh yes, you are right. This change is supposed to be on top of another change which replaces `ProfileInlineLimitMin` with a multiplifier `ProfileInlineGrowthLimitMin`.
Abandoning this for now until rebased.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138231/new/
https://reviews.llvm.org/D138231
More information about the llvm-commits
mailing list