[PATCH] D138026: [ARM][AArch64] Use StringRef in TargetParser structs

Tomas Matheson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 10:49:26 PST 2022


tmatheson added a comment.

In D138026#3934392 <https://reviews.llvm.org/D138026#3934392>, @tschuett wrote:

> `Optional<StringRef>` is too verbose to model the invalid case?

Sorry I missed this before I pushed. Optional is a potential option (heh), it wasn't done here simply because I'm trying to keep the changes incremental. I will make a follow up patch if I can find something reasonable that works.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138026/new/

https://reviews.llvm.org/D138026



More information about the llvm-commits mailing list