[PATCH] D138216: [AMDGPU] Intrinsic to expose s_wait_event for export ready

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:2071
+def int_amdgcn_wait_event_export_ready :
+  Intrinsic<[], [], [IntrNoMem, IntrHasSideEffects, IntrWillReturn]
+>;
----------------
Why is the immediate missing from the intrinsic? Should this also have the ClangBuiltin name declared here?


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.wait.event.ll:1
+; RUN: llc -march=amdgcn -verify-machineinstrs -mcpu=gfx1100 < %s | FileCheck -check-prefix=GCN %s
+; RUN: llc -global-isel -march=amdgcn -verify-machineinstrs -mcpu=gfx1100 < %s | FileCheck -check-prefix=GCN %s
----------------
Should use an explicit -global-isel=0


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.wait.event.ll:9
+entry:
+  call void @llvm.amdgcn.wait.event.export.ready() #1
+  ret void
----------------
All the other scalar intrinsics have the s in the name 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138216/new/

https://reviews.llvm.org/D138216