[PATCH] D137939: [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push CatchRetScope early

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added inline comments.


================
Comment at: clang/test/CodeGenObjCXX/arc-exceptions-seh.mm:36
+// CHECK:           call
+// CHECK:           do_something
+// CHECK:           [ "funclet"(token [[CATCHPAD]]) ]
----------------
rnk wrote:
> Don't we need an exceptional cleanup here to release the exception if `do_something` or `may_throw` throw?
Thanks, that's a very good point! `-fobjc-arc-exceptions` tells clang to generate invokes here instead of calls and then we can check funclet tokens in cleanup pads too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137939/new/

https://reviews.llvm.org/D137939