[PATCH] D137767: [AMDGPU] Make aperture registers 64 bit

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 08:13:25 PST 2022


arsenm added a comment.

In D137767#3933143 <https://reviews.llvm.org/D137767#3933143>, @Pierre-vh wrote:

> In D137542 <https://reviews.llvm.org/D137542> you said I shouldn't set a register class. If I add a register class, how will it help? Should I add the new class & keep using the constrain?

The complaint was mostly about where you set the class on the virtual register, during legalize and not during the select of the copy. Here I mean you may want a different register class to represent the use restriction where you want everything else, but to exclude the aperture regs


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137767/new/

https://reviews.llvm.org/D137767



More information about the llvm-commits mailing list