[PATCH] D133012: [AMDGPU] Add subtarget feature for MAD_U64/I64 bug on GFX11

Mirko Brkusanin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 07:28:27 PST 2022


mbrkusanin added a comment.

In D133012#3933895 <https://reviews.llvm.org/D133012#3933895>, @Joe_Nash wrote:

> In D133012#3933756 <https://reviews.llvm.org/D133012#3933756>, @mbrkusanin wrote:
>
>> - By overriding opName (or PseudoInstr of tablegen record) for _strict pseudo we can have both pseudos select into same real instruction, so now we don't need two.
>
> This is a creative use of the opName, but I think it probably hinders readability. No other instructions are doing this, so when I look at definition of the Real instruction it seems to refer to the non-strict pseudo.

Well, it refers to both in a way. I changed the one it actually uses for initialization to be _strict pseudo which in turns uses same name as non strict one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133012/new/

https://reviews.llvm.org/D133012



More information about the llvm-commits mailing list