[PATCH] D133321: [Assignment Tracking][24/*] Always RemoveRedundantDbgInstrs in instcombine in assignment tracking builds

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 07:19:53 PST 2022


jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/instcombine/do-not-remove-redundant-dbg.ll:6-9
+;; Check that instcombine does not remove redundant debug intrinsics when
+;; assignment tracking is turned off. This test is here to check the existing
+;; behaviour is maintained. If it is discovered that it is profitable to remove
+;; these intrinsics in instcombine then it's okay to remove this test.
----------------
Full marks for writing good test explanations


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133321/new/

https://reviews.llvm.org/D133321



More information about the llvm-commits mailing list