[PATCH] D138203: [AArch64][InstCombine] Simplify repeated complex patterns in dupqlane

[Nuno Lopes via Phabricator via llvm-commits]

nlopes added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1435
+  Value *InsertEltX = Builder.CreateInsertElement(
+      UndefValue::get(CurrentValue->getType()), RSequence[1], Zero);
+  Value *InsertEltY =
----------------
Please use PoisoValue here and whenever possible. We are trying to remove undef from LLVM.
Actually, here you can even use a different API: `CreateInsertElement(Type *VecTy, Value *NewElt, Value *Idx)`

Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138203/new/

https://reviews.llvm.org/D138203