[PATCH] D133296: [Assignment Tracking][13/*] Account for assignment tracking in SROA

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:201
+    // If we haven't created a DIAssignID ID do that now and attach it to Inst.
+    if (!NewID) {
+      NewID = DIAssignID::getDistinct(Ctx);
----------------
Orlando wrote:
> jmorse wrote:
> > I believe this is always true, probably because of some refactors.
> It's initialized to `nullptr` outside of this loop.
Ah, missed the outer loop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133296/new/

https://reviews.llvm.org/D133296