[PATCH] D133310: [Assignment Tracking][15/*] Account for assignment tracking in simplifycfg

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM, with one or two questions, and the middle test needs `-simplifycfg` adding



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:2542
+    // The value stored is still conditional, but the store itself is now
+    // unconditonally run, so we must be sure that any linked dbg.assign
+    // intrinsics are tracking the new stored value (the result of the
----------------
s/run/executed/, for formality?


================
Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/simplifycfg/sink-erase.ll:1
+; RUN: opt %s -S -o - -experimental-assignment-tracking | FileCheck %s
+
----------------
This needs to run simplifycfg, right?


================
Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/simplifycfg/sink-erase.ll:27-29
+;; Check that there is only one dbg.assign (for c) in the final block.
+; CHECK: for.inc.split.5:
+; CHECK-COUNT-1: call void @llvm.dbg.assign
----------------
Is that just checking a single block, and if not should there be an implicit-check-not happening?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133310/new/

https://reviews.llvm.org/D133310