[PATCH] D131551: [RISCV] Fold vector binary operatrion into select with identity constant.

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1214
+
+  if (VT.getScalarSizeInBits() >= Subtarget.getELEN())
+    return false;
----------------
craig.topper wrote:
> This is imprecise for FP which has a different ELEN for Zve64f and Zve32x.
> 
> I think you can ignore it for scalable vectors since those elements always have to be supported if we see them. For fixed vectors we should check isTypeLegal.
Done, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131551/new/

https://reviews.llvm.org/D131551