[PATCH] D137422: [DAGCombine] Generalize foldSelectCCToShiftAnd

[Mikhail Gudim via Phabricator via llvm-commits]

mgudim added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/select-to-shift-and.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+
----------------
craig.topper wrote:
> mgudim wrote:
> > This is a target-independent optimization, so I am not sure how to properly test it. I included this file only to demonstrate how the optimization works.
> > 
> > Please let me know what you think a proper place / form for this test should be.
> Why did you stop on MIR instead of assembly?
Since we are testing something in `ISel` I thought it would make sense to run only `ISel`. 

I do see that most of other tests go all the way to assembly. I am fine with either way. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137422/new/

https://reviews.llvm.org/D137422