[PATCH] D119013: [ArgPromotion][AMDGPU] New MSSA-based function argument promotion pass with input/output argument support

Nuno Lopes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 00:21:17 PST 2022


nlopes added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/MSSAArgPromotion.cpp:792
+    }
+    return UndefValue::get(ArgInfo.ArgType);
+  };
----------------
Please use PoisonValue instead of UndefValue whenever possible as we are trying to remove undef from LLVM.
Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119013/new/

https://reviews.llvm.org/D119013



More information about the llvm-commits mailing list