[PATCH] D136749: [Don't Commit] [DRAFT] Workaround the example in 57861

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 23:02:04 PST 2022


ChuanqiXu updated this revision to Diff 476020.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136749/new/

https://reviews.llvm.org/D136749

Files:
  llvm/lib/Transforms/Coroutines/CoroFrame.cpp


Index: llvm/lib/Transforms/Coroutines/CoroFrame.cpp
===================================================================
--- llvm/lib/Transforms/Coroutines/CoroFrame.cpp
+++ llvm/lib/Transforms/Coroutines/CoroFrame.cpp
@@ -1817,6 +1817,23 @@
           AliasPtrTyped, [&](Use &U) { return DT.dominates(CB, U); });
     }
   }
+
+  if (Shape.ABI == coro::ABI::Switch && Shape.SwitchLowering.PromiseAlloca) {
+    AllocaInst *PA = Shape.SwitchLowering.PromiseAlloca;
+    bool HasAccessingPromiseBeforeCB = llvm::any_of(PA->users(), [&](User *U){
+      auto *Inst = cast<Instruction>(U);
+
+      return !Inst->isDebugOrPseudoInst() &&
+             !Inst->isLifetimeStartOrEnd() &&
+             !DT.dominates(CB, Inst);
+    });
+    if (HasAccessingPromiseBeforeCB) {
+      Builder.SetInsertPoint(Shape.getInsertPtAfterFramePtr());
+      auto *G = GetFramePointer(PA);
+      auto *Value = Builder.CreateLoad(PA->getAllocatedType(), PA);
+      Builder.CreateStore(Value, G);
+    }
+  }
 }
 
 // Moves the values in the PHIs in SuccBB that correspong to PredBB into a new


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136749.476020.patch
Type: text/x-patch
Size: 1076 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221117/101718ea/attachment.bin>


More information about the llvm-commits mailing list