[PATCH] D137834: [Support] Reduce Dependence on Host.h

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli added a comment.

Hi - I have noticed that there are tabes indenting the code I stead os spaces. Is this `clang-format` doing it?

Francesco



================
Comment at: llvm/lib/Support/SHA256.cpp:246-252
+    // Just copy the current state
+    for (int i = 0; i < 8; i++) {
+      HashResult[i] = InternalState.State[i];
+    }
+  } else {
+    // Swap byte order back
+    for (int i = 0; i < 8; i++) {
----------------
Tabs?


================
Comment at: llvm/lib/Support/SHA256.cpp:253
+    for (int i = 0; i < 8; i++) {
+      HashResult[i] = sys::getSwappedBytes(InternalState.State[i]);
+    }
----------------
This is an improvement that is unrelated to making libSupport less dependent on Host.cpp. I'd suggest to either mention the extra change in the commit message, or factor it out as a separate commit (up to you).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137834/new/

https://reviews.llvm.org/D137834