[PATCH] D138016: [Object] Add some more LoongArch support

[Lu Weining via Phabricator via llvm-commits]

SixWeining added inline comments.


================
Comment at: llvm/lib/Object/ELF.cpp:226-227
     break;
+  case ELF::EM_LOONGARCH:
+    return ELF::R_LARCH_RELATIVE;
   default:
----------------
Seems this can be tested in `llvm/unittests/Object/ELFObjectFileTest.cpp`:
```
  // ELF relative relocation type test.
  TEST(ELFObjectFileTest, RelativeRelocationTypeTest) {
    EXPECT_EQ(ELF::R_CKCORE_RELATIVE, getELFRelativeRelocationType(ELF::EM_CSKY));
  }
```

or  in `llvm/unittests/Object/ELFTest.cpp`:
```
TEST(ELFTest, getELFRelativeRelocationType) {
  EXPECT_EQ(ELF::R_VE_RELATIVE, getELFRelativeRelocationType(EM_VE));
}
```


================
Comment at: llvm/lib/Object/ELFObjectFile.cpp:344
 
+SubtargetFeatures ELFObjectFileBase::getLoongArchFeatures() const {
+  SubtargetFeatures Features;
----------------
Maybe similar tests could be added like RISCV in D42629.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138016/new/

https://reviews.llvm.org/D138016