[PATCH] D137939: [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push CatchRetScope early

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Thanks, I can see the bug here:
https://gcc.godbolt.org/z/1xjMYarT9
You can see how storeStrong cleanup uses the catchpad funclet when it should not.



================
Comment at: clang/test/CodeGenObjCXX/arc-exceptions-seh.mm:36
+// CHECK:           call
+// CHECK:           do_something
+// CHECK:           [ "funclet"(token [[CATCHPAD]]) ]
----------------
Don't we need an exceptional cleanup here to release the exception if `do_something` or `may_throw` throw?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137939/new/

https://reviews.llvm.org/D137939