[PATCH] D137905: [GlobalISel] Add new G_INVOKE_REGION_START/END instructions to fix an EH bug

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 15:11:46 PST 2022


aemerson added a comment.

In D137905#3931866 <https://reviews.llvm.org/D137905#3931866>, @paquette wrote:

> Does `G_INVOKE_REGION_START` work with the `terminators()` iterator?

It would not. `terminators()` uses `getFirstTerminator()` as the start iterator for the range, and therefore it only counts terminators which are adjacent instructions at the end of the block.

I'm open to other approaches to fix this, its just that a new terminator seemed like the least hacky approach, but it's not without it's own issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137905/new/

https://reviews.llvm.org/D137905



More information about the llvm-commits mailing list