[PATCH] D136237: [BasicBlockSections] avoid insertting redundant branch to fall through blocks

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl added a comment.

Has this been revised yet? I see you have updated the patch but my comments are still "Not Done".



================
Comment at: llvm/lib/CodeGen/BasicBlockSections.cpp:153-155
+    //        order, or
+    //     3- the terminator of the block is an unconditional branch to its
+    //        fallthrough.
----------------
rahmanl wrote:
> This comment is incorrect. If it has an unconditional branch to its fallthrough, then we *don't* need an additional jump.
Still pending.
You can just remove the third item (it's implicitly followed from "needs an explicit unconditional branch").


================
Comment at: llvm/test/CodeGen/X86/basic-block-sections-redundant-br.ll:1
+; Test if basic block sections pass can skip inserting a unconditional branch when a basic block
+; already has an unconditional branch to its fallthrough block.
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136237/new/

https://reviews.llvm.org/D136237