[PATCH] D138078: [CodeGenPrepare] split critical indirect edges from callbr w/ outputs

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 13:56:13 PST 2022


nickdesaulniers added a comment.

In D138078#3931843 <https://reviews.llvm.org/D138078#3931843>, @arsenm wrote:

> To me it sounds like the kind of issue we deal with in FinalizeISel to hack around dag limitations

I think it would be MUCH better to do this work BEFORE ISEL, otherwise in FinalizeISEL we have to generate bad code then bend over backwards to clean up.  If we do this BEFORE ISEL, we get the expected codegen for free.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138078/new/

https://reviews.llvm.org/D138078



More information about the llvm-commits mailing list