[PATCH] D119547: [libc][bazel] Add tests to the bazel build

Wed Nov 16 13:09:11 PST 2022

gchatelet added inline comments.

================
Comment at: utils/bazel/llvm-project-overlay/libc/test/src/math/BUILD.bazel:262-263
+
+# "sqrtl" test is currently skipped on Aarch64 because of
+# insufficient precision in MPFR leading to https://hal.archives-ouvertes.fr/hal-01091186/document
+math_test(
----------------
lntue wrote:
> I think this comment does not apply anymore.  Can you add a `TODO` for me to double check this on an aarch64 machine and re-enable the test?  Thanks,
Just tested on an aarch64 machine with the following dependencies and it passes.
Get:1 http://deb.debian.org/debian bullseye/main arm64 libgmpxx4ldbl arm64 2:6.2.1+dfsg-1+deb11u1 [337 kB]
Get:2 http://deb.debian.org/debian bullseye/main arm64 libgmp-dev arm64 2:6.2.1+dfsg-1+deb11u1 [625 kB]
Get:3 http://deb.debian.org/debian bullseye/main arm64 libmpfr-dev arm64 4.1.0-3 [236 kB]

I'll simplify the target then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119547/new/

https://reviews.llvm.org/D119547