[PATCH] D138095: [asan] Keep Itanium mangled names in global metadata

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 11:30:21 PST 2022


dblaikie added a comment.

Huh, fascinating - so we used the unmangled name as a symbol name, punctuation, spaces, and all?

(interesting to know that sanitizers end up with their own copies of mangled names too - another thing we could consider deduplicating/maybe sharing with some debug info/symbol table reductions at some point (I guess if we just simplify mangled names enough - use hashes, etc, this'd fall out naturally for the sanitizers (though all demanglers would need to have access to some side table of hash->mangled name table, which I guess sanitizers need at runtime, so couldn't be dropped during linking (previously had considered this strategy since the linker would need to produce good diagnostics - but I guess runtime symbolizers need useful symbol names too, etc)))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138095/new/

https://reviews.llvm.org/D138095



More information about the llvm-commits mailing list