[PATCH] D137905: [GlobalISel] Add new G_INVOKE_REGION_START/END instructions to fix an EH bug

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 10:12:02 PST 2022


paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:836
+    if (FirstTerminator->getOpcode() != TargetOpcode::G_INVOKE_REGION_START) {
+      report("Non-terminator instruction after the first terminator", MI);
+      errs() << "First terminator was:\t" << *FirstTerminator;
----------------
aemerson wrote:
> paquette wrote:
> > MachineVerifier test?
> I couldn’t think of anything to verify since these have no operands or results
probably just a test that shows that we don't get an error when this precedes a non-terminator


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137905/new/

https://reviews.llvm.org/D137905



More information about the llvm-commits mailing list