[PATCH] D138141: [amdgpu] Reimplement LDS lowering

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

This could (and should) be prettier, and there should be lit tests for the (gated behind the default =module, so inactive here) table lowering pass. This has been through epsdb in the hybrid mode and set up to force all lowerings through the table lookup so there's a credible chance it works correctly.

One path forward is:

- land this in the current somewhat unpolished state and possibly toggle the default in rocm to hybrid immediately to unblock the inlining experimentation
- a follow up patch changes the default to hybrid along with a bunch of lit tests showing how the table lookup behaves
- I refactor this implementation from behind more paranoid test coverage, in particular to walk the functions list less often

Alternatively I'll iterate on it in phab until the inessential complexity is reduced enough. It's a bigger patch than I'd have liked, but at least the complicated backend lowering landed separately in D125060 <https://reviews.llvm.org/D125060>. This is mostly an IR transform.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138141/new/

https://reviews.llvm.org/D138141