[PATCH] D136249: [NFC][SelectionDAG][DebugInfo] Refactor DanglingDebugInfo class

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

(accidentally didn't submit an inline reply)



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:111
     DanglingDebugInfo() = default;
     DanglingDebugInfo(const DbgValueInst *di, DebugLoc DL, unsigned SDNO)
+        : DI(di), SDNodeOrder(SDNO) {}
----------------
StephenTozer wrote:
> DL can be removed as an argument now, right? Also just as a point of style, could you drive-by change the first argument to use correct casing?
Good point, and similarly I've now removed the `DebugLoc` parameter from `addDanglingDebugInfo`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136249/new/

https://reviews.llvm.org/D136249