[PATCH] D129066: [AArch64][CodeGen] Add AArch64 support for complex deinterleaving

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 02:06:53 PST 2022


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

I was hoping we could get some correctness results for the MVE side overnight, but out internal testing seems pretty broken for other reasons. I don't see anything that is complex number related, so hopefully this is OK.

So long as you have done some testing, LGTM.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:23280-23281
+
+  assert((TyWidth >= 128 && llvm::isPowerOf2_32(TyWidth)) ||
+         TyWidth == 64 && "Vector type must be either 64 or a power of 2 that is at least 128");
+
----------------
Formatting, and it probably wants brackets around the ||


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129066/new/

https://reviews.llvm.org/D129066



More information about the llvm-commits mailing list