[PATCH] D137933: [llvm-debuginfo-analyzer] 10 - Smart Pointers

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVSymbol.h:76
   LVSymbol &operator=(const LVSymbol &) = delete;
-  ~LVSymbol() { delete Locations; }
+  ~LVSymbol() = default;
 
----------------
dblaikie wrote:
> Remove this default?
Keep it just for consistency with other LVScopexxx definitions.

May be in a post-commit: remove all default dtors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137933/new/

https://reviews.llvm.org/D137933