[PATCH] D137767: [AMDGPU] Make aperture registers 64 bit
Pierre van Houtryve via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 16 00:34:57 PST 2022
Pierre-vh added a comment.
In D137767#3927784 <https://reviews.llvm.org/D137767#3927784>, @arsenm wrote:
> In D137767#3927154 <https://reviews.llvm.org/D137767#3927154>, @Pierre-vh wrote:
>
>> Note: I can't use COPY in D137542 <https://reviews.llvm.org/D137542> because otherwise it'll "simplify" it and we end up with instructions that use the _HI register variants - which shouldn't be there and are just here because TableGen needs them/I get hundreds of crashes without it. It seems to assume there'll be sub1 for every reg in the class.
>
> That either means we're missing a class restriction or need a reserve
Ah the class restriction was it! I fixed it. I got confused and was using SREG_64 (includes aperture register) for the COPY dst register, but if I use SGPR (doesn't include it) then copy coalescing won't mess it up
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137767/new/
https://reviews.llvm.org/D137767
More information about the llvm-commits
mailing list